feat(zipapp): support EXTRACT_ROOT env var for __main__.py invocations#3682
Merged
rickeylev merged 4 commits intobazel-contrib:mainfrom Apr 5, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to specify a custom extraction root for Python zipapps via the RULES_PYTHON_EXTRACT_ROOT environment variable, allowing for persistent extraction locations instead of temporary directories. Feedback was provided regarding potential race conditions and file corruption when multiple instances extract to the same fixed location simultaneously. Additionally, there is an inconsistency in the use of os.path.join versus a direct join import, and a concern that the new -XRULES_PYTHON_ZIP_DIR flag is not passed consistently when a custom extraction root is used.
rickeylev
changed the title
aignas
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes zipapps that are invoked using the
__main__.pyentry point(i.e.
python foo.zip) respect the RULES_PYTHON_EXTRACT_ROOT env var, whichallows some control over where they extract themselves.